Serve image assets from Khoj domain, not directly from S3 bucket #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debanjum
commented
May 4, 2024
debanjum
commented
- f6ce9ff Serve generated images from Khoj domain instead of directly from S3
- 274b1e7 Rename assets URL from Khoj S3 bucket to assets.khoj.dev
debanjum
force-pushed
the
server-image-assets-from-khoj-domain
branch
from
f6ce9ff
to
e824d10
Compare
Server khoj assets from khoj domain
Use CNAME to forward requests from the khoj subdomain to the equivalent S3 bucket
debanjum
force-pushed
the
server-image-assets-from-khoj-domain
branch
from
e824d10
to
80cbaca
Compare
sabaimran
reviewed
May 7, 2024
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
src/khoj/database/management/commands/serve_generated_images_from_server.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.