Create controller framework and move validations to offline processing #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovsepy
reviewed
Feb 20, 2024
frontend/package.json
Outdated
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "proxy": "http://localhost:20001", | |||
This was referenced Feb 20, 2024
|
This PR becomes very important for Perf optimization effort. |
|
The failing 2 validation tests are because of cache is not reloaded yet, just require timeout and refresh the page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Moves calculating namespace/cluster-wide validations into a "controller" for offline processing. Individual object validations are still done "on demand" within the request. Calculates validations every 30s. Does not yet watch istio objects to re-calculate validations when they change.
Steps to test the PR
Automation testing
Covered by newly added "controller" tests.
Issue reference
Relates to #7076