Gesture: Add toggle for orientation lock #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a gesture to toggle the existing "Lock auto rotation to current orientation" option. This is an option that I tended to change relatively often as I switch between reading in bed (and swapping hands) and reading while eating or doing other things that make it harder to hold my device.
I'm hoping I've done everything correctly (and I've tested and verified it works on my device) but if not, let me know and I'll do my best to fix it up.
There's perhaps other cleanups/changes that could be made here since it's a bit confusing that the rotation options are under "Screen" in the settings but under "Device" in the gestures but I just wanted to get this working for me :)
This change is