Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update face detection (YuNet) #2851

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cjpurackal
Copy link
Member

@cjpurackal cjpurackal commented Mar 22, 2024

Changes

Fixes #1781
Related to #2559

Type of change

  • 馃摎 Documentation Update
  • 馃И Tests Cases
  • 馃悶 Bug fix (non-breaking change which fixes an issue)
  • 馃敩 New feature (non-breaking change which adds functionality)
  • 馃毃 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 馃摑 This change requires a documentation update

Checklist

  • Support different configs
  • ONNX compatible

@cjpurackal cjpurackal added this to the kornia v0.7.3 milestone Mar 22, 2024
@cjpurackal cjpurackal marked this pull request as draft March 22, 2024 11:43
@cjpurackal cjpurackal marked this pull request as ready for review March 22, 2024 17:00
Copy link
Member

@johnnv1 johnnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests and docs updates? overall, it is fine, but we will break back compatibility here, add these changes, and deprecate the old version.

@cjpurackal cjpurackal marked this pull request as draft March 25, 2024 11:18
Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • would be interesting to see whether we can export to ONNX and torch compile the model
  • Would be great too, to verify if there鈥檚 any speed performance difference


url: str = "https://github.com/kornia/data/raw/main/yunet_final.pth"

class BackboneConfig(TypedDict):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opinion about dataclass vs typed dict In these configs? related to #2093

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense 馃憤

@johnnv1 johnnv1 mentioned this pull request Apr 9, 2024
15 tasks
@cjpurackal cjpurackal marked this pull request as ready for review May 5, 2024 17:59
@cjpurackal
Copy link
Member Author

cjpurackal commented May 5, 2024

  • would be interesting to see whether we can export to ONNX and torch compile the model

    • Would be great too, to verify if there鈥檚 any speed performance difference

I'm able to convert the model to ONNX. Inference works. I did some very basic tests with torch.compile and the resulting model was 10x slower. I'm unsure why. I'll investigate this later

@edgarriba
Copy link
Member

@cjpurackal i think you need to rebase from main in order to fix the ci breaks

@cjpurackal cjpurackal marked this pull request as draft May 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the FaceDetection API based on the changes from libfacedetection.train API
3 participants