-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update face detection (YuNet) #2851
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add tests and docs updates? overall, it is fine, but we will break back compatibility here, add these changes, and deprecate the old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- would be interesting to see whether we can export to ONNX and torch compile the model
- Would be great too, to verify if there鈥檚 any speed performance difference
kornia/contrib/face_detection.py
Outdated
|
||
url: str = "https://github.com/kornia/data/raw/main/yunet_final.pth" | ||
|
||
class BackboneConfig(TypedDict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any opinion about dataclass vs typed dict In these configs? related to #2093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense 馃憤
I'm able to convert the model to ONNX. Inference works. I did some very basic tests with torch.compile and the resulting model was 10x slower. I'm unsure why. I'll investigate this later |
@cjpurackal i think you need to rebase from main in order to fix the ci breaks |
88dd077
to
a92bc17
Compare
for more information, see https://pre-commit.ci
a92bc17
to
843daa2
Compare
Changes
Fixes #1781
Related to #2559
Type of change
Checklist