Refactor SOLD2 and WunschLineMatcher Dict Config to Dataclasses #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lappemic
changed the title
|
Hey @edgarriba, this is still an addition the the Dict to Dataclass refactoring. As far as i see, the ci error is the same as before in #2899. Cc @johnnv1 |
1 task
johnnv1
approved these changes
May 16, 2024
johnnv1
changed the title
15 tasks
edgarriba
approved these changes
May 17, 2024
|
hey, @lappemic the failing tutorial is related to sold2, could you check it? |
auto-merge was automatically disabled
May 17, 2024 12:15
Head branch was pushed to by a user without write access
|
@johnnv1 found the error in the tutorials (was related to wrongliy configured |
yeah, it's fine, tks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SOLD2 and WunschLineMatcher configurations to use dataclasses, aligning with issue #2093. It builds on the changes from PR #2899, which consolidated SOLD2 dataclasses into kornia.feature.sold2.structures.