Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade feedparser #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

8W9aG
Copy link

@8W9aG 8W9aG commented May 30, 2021

@decorouz
Copy link

  • Currently the feedparser specified in the requirements does not work with Python 3.9.x due to this issue: kurtmckee/feedparser#206
  • Upgrade the feedparser so pygooglenews works with python 3.9.x
  • Currently the feedparser specified in the requirements does not work with Python 3.9.x due to this issue: kurtmckee/feedparser#206
  • Upgrade the feedparser so pygooglenews works with python 3.9.x

Line 93 in feedparser.py change _base64decode = getattr(base64, 'decodebytes', base64.decodestring) to base64.decodebytes.
This is based on the fix by @kurtmckee

@8W9aG
Copy link
Author

8W9aG commented Aug 15, 2021

Thanks for the approval, cannot merge myself due to permissions

@Pyth3rEx
Copy link

I know just trying to spam the notifications enough to get the owner to notice :P

@Alyetama Alyetama mentioned this pull request Oct 5, 2021
@NicolasCaousGV
Copy link

To anyone who wants to use this lib but can't install, you can force the dependencies to be a specific version this way:

python -m pip install "beautifulsoup4==4.9.1"
python -m pip install "dateparser==0.7.6"
python -m pip install "requests==2.24.0"
python -m pip install "feedparser==6.0.8"
python -m pip install --no-deps pygooglenews

This should work. (If it doesn't, check if the versions have changed in pyproject.toml for some reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants