Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hlint rule #451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ulidtko
Copy link

@ulidtko ulidtko commented Oct 26, 2023

Hi @vrom911 πŸ‘‹ Long-time fan of Kowainik, here's a first contribution.

I was writing something with Relude, and had a sudden brainfart failing to remember how to say toList πŸ˜…
Instead I wrote foldr (:) [] β€” expecting Relude's HLint ruleset to remind me a less clumsy wording β€” but alas, it didn't say anything! That I was shocked, says something about the quality of kowainik stuff πŸ˜‰

Checklist

  • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
  • I've generated the new .hlint.yaml file (see this instructions).
  • I've updated the CHANGELOG with the short description of my latest changes.
    β€” πŸ€” Prolly not worth it?..

Unquoted `on` manually reverted, in rule about Data.Function.on
@ulidtko ulidtko requested a review from vrom911 as a code owner October 26, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant