feat(circom): enable circom proof generation without compilation #419
+1,544
−844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
feat/enable-circom-proof-generation-without-compilation
branch
4 times, most recently
from
e216c3c
to
3b51bd2
Compare
dongchangYoo
requested changes
May 20, 2024
chokobole
force-pushed
the
feat/enable-circom-proof-generation-without-compilation
branch
from
3b51bd2
to
643a0ca
Compare
chokobole
force-pushed
the
feat/enable-circom-proof-generation-without-compilation
branch
3 times, most recently
from
9de7df5
to
77a26de
Compare
This modifes the (de)serialization process to exclude the `infinity` flag, aligning it with (de)serialization from/to JSON. This change significantly reduces output size, given that most points are not at infinity.
Refactor the `R1CSParser::Parse()` method into a standalone function to avoid unnecessary instantiation of `R1CSParser` objects solely for method invocation.
Refactor the `ZKeyParser::Parse()` method into a standalone function to avoid unnecessary instantiation of `ZKeyParser` objects solely for method invocation.
chokobole
force-pushed
the
feat/enable-circom-proof-generation-without-compilation
branch
from
77a26de
to
09f238c
Compare
chokobole
deleted the
feat/enable-circom-proof-generation-without-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables proof generation with the same interface as rapidsnark