[pkg/volume] Changed to use sets.Set[string] instead of sets.String #124740
+66
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
removed
the
do-not-merge/needs-sig
k8s-ci-robot
added
the
needs-rebase
bells17
force-pushed
the
use-sets-set-string
branch
from
03242f0
to
ef1d3a1
Compare
k8s-ci-robot
added
size/XXL
bells17
force-pushed
the
use-sets-set-string
branch
from
ef1d3a1
to
14bd183
Compare
k8s-ci-robot
added
size/L
bells17
force-pushed
the
use-sets-set-string
branch
from
14bd183
to
5e72a6a
Compare
bells17
force-pushed
the
use-sets-set-string
branch
from
5e72a6a
to
8cf18d1
Compare
|
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
k8s-ci-robot
added
the
priority/important-longterm
k8s-ci-robot
added
lgtm
|
LGTM label has been added. Git tree hash: 6246b1130f14453d4efa6e992a92dc44055ea08e
|
|
/assign @xing-yang For minor pkg/volume change approval. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bells17, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replaced sets.String with sets.Set[string] in pkg/volume.
(This is because sets.String is marked as Deprecated.)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
ref: #124439 (comment)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: