feat: check connectivity outside minikube once it fails #18859

ComradeProgrammer · 2024-05-12T13:47:53Z

feat: check connectivity outside minikube once it fails

FIX #18754
After

$ ./out/minikube start       
😄  minikube v1.33.0 on Darwin 14.4.1 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
📌  Using Docker Desktop driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44 ...
🔥  Creating docker container (CPUs=2, Memory=6100MB) ...
❗  This container is having trouble accessing https://registry.k8s.io inside the minikube
💡  To pull new external images, you may need to configure a proxy: https://minikube.sigs.k8s.io/docs/reference/networking/proxy/
❗  This container is also having trouble accessing https://registry.k8s.io outside the minikube 
🐳  Preparing Kubernetes v1.30.0 on Docker 26.1.1 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

This container is also having trouble accessing https://registry.k8s.io outside the minikube is also printed on the console

k8s-ci-robot · 2024-05-12T13:47:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2024-05-12T13:48:01Z

Can one of the admins verify this patch?

medyagh · 2024-05-13T01:49:50Z

pkg/minikube/node/start.go

@@ -856,14 +856,20 @@ func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
 	}


we should come up with a Curl equivalent of Windows command if they run it in powershell

pkg/minikube/node/start.go

k8s-ci-robot requested review from afbjorklund and spowelljr May 12, 2024 13:47

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024

medyagh requested changes May 13, 2024

View reviewed changes

medyagh requested changes May 15, 2024

View reviewed changes

pkg/minikube/node/start.go Outdated Show resolved Hide resolved

feat: check connectivity outside minikube once it fails

31bd7d0

ComradeProgrammer force-pushed the 18754 branch from ea787b1 to 31bd7d0 Compare May 20, 2024 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: check connectivity outside minikube once it fails #18859

feat: check connectivity outside minikube once it fails #18859

ComradeProgrammer commented May 12, 2024

k8s-ci-robot commented May 12, 2024

minikube-bot commented May 12, 2024

medyagh May 13, 2024

		@@ -856,14 +856,20 @@ func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
		}

feat: check connectivity outside minikube once it fails #18859

Are you sure you want to change the base?

feat: check connectivity outside minikube once it fails #18859

Conversation

ComradeProgrammer commented May 12, 2024

k8s-ci-robot commented May 12, 2024

minikube-bot commented May 12, 2024

medyagh May 13, 2024

Choose a reason for hiding this comment