Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 3166 #3404

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix issue 3166 #3404

merged 2 commits into from
May 28, 2024

Conversation

andyfengHKU
Copy link
Contributor

I need to check this against CI first.

@andyfengHKU andyfengHKU force-pushed the try-issue-3166 branch 2 times, most recently from d7a5d4f to f395a9d Compare May 7, 2024 19:04
ray6080
ray6080 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good design to fill the flip vector inside rel table scan. the reason is simply because that info is passed down from operator, while not relying on anything inside storage. Better move the filling of flip vector into operators.

src/include/storage/store/rel_table.h Outdated Show resolved Hide resolved
src/function/struct/struct_pack_function.cpp Outdated Show resolved Hide resolved
src/function/struct/struct_pack_function.cpp Show resolved Hide resolved
src/include/expression_evaluator/node_rel_evaluator.h Outdated Show resolved Hide resolved
src/include/expression_evaluator/node_rel_evaluator.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU changed the title [DO NOT REVIEW] Try issue 3166 Fix issue 3166 May 28, 2024
@andyfengHKU andyfengHKU merged commit baf4fb3 into master May 28, 2024
@andyfengHKU andyfengHKU deleted the try-issue-3166 branch May 28, 2024 20:47
@andyfengHKU andyfengHKU mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyfengHKU @ray6080