New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C Api Enhancements #3457

Merged

MSebanc merged 21 commits into master from c-api-enhancements

May 27, 2024

Collaborator

MSebanc commented May 7, 2024 •

edited

No description provided.

MSebanc and others added 12 commits

May 7, 2024 09:26


          C Api Enhancements

9db83f5


          Run clang-format

bd68e75


          Minor fixes

3f92293


          Added utility functions for timestamp, interval, and date

5108c73


          Merge branch 'master' into c-api-enhancements

6e082ec


          Run clang-format

ace8b8f


          Merge branch 'master' into c-api-enhancements

9c4eee3


          Minor fix

0dccde4


          Run clang-format

65f6b1e


          Minor changes

9c4949b


          Minor changes

6e9f226


          Minor changes

b1ad484

MSebanc marked this pull request as ready for review

May 11, 2024 00:18

MSebanc requested a review from mewim

May 11, 2024 00:19

mewim reviewed

View reviewed changes

src/c_api/prepared_statement.cpp Outdated Show resolved Hide resolved

mewim reviewed

View reviewed changes

src/c_api/query_result.cpp Outdated Show resolved Hide resolved

mewim reviewed

View reviewed changes

src/c_api/query_result.cpp Show resolved Hide resolved

mewim reviewed

View reviewed changes

src/c_api/value.cpp Outdated Show resolved Hide resolved

mewim reviewed

View reviewed changes

examples/c/main.c Show resolved Hide resolved

mewim reviewed

View reviewed changes

src/c_api/value.cpp Show resolved Hide resolved

mewim reviewed

View reviewed changes

src/c_api/value.cpp Show resolved Hide resolved

Collaborator

mewim commented May 21, 2024

I did not check the test cases very carefully. But in general, for functions that can return KuzuError, it would be nice to also check the error cases, as long as they are easy to produce.

mewim requested changes

View reviewed changes

Collaborator

mewim left a comment

Nice PR overall, with a few imprvements needed (see my comments).

MSebanc and others added 7 commits

May 24, 2024 14:41


          Fixed feedback

431fc59


          Run clang-format

d0a9939


          Minor fixes

3e62d15


          Merge branch 'c-api-enhancements' of https://github.com/kuzudb/kuzu i…

b4e2460

…nto c-api-enhancements


          Minor changes

977044c


          Merge branch 'master' into c-api-enhancements

94d6e4e


          Minor fixes

ba954b8

MSebanc added 2 commits

May 24, 2024 17:18


          Minor fixes

1e35fa6


          Minor fixes

8c41844

MSebanc requested a review from mewim

May 25, 2024 04:23

mewim approved these changes

View reviewed changes

MSebanc merged commit e07db38 into master

18 checks passed

MSebanc deleted the c-api-enhancements branch

May 27, 2024 15:01

benjaminwinger mentioned this pull request

Windows/Shared lib/Dll: clib free can't be used on string-results with non shared CRT #2527

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment