Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code sample in TS evaluation quickstart #181

Closed
wants to merge 2 commits into from
Closed

Fix code sample in TS evaluation quickstart #181

wants to merge 2 commits into from

Conversation

jacoblee93
Copy link
Contributor

@hinthornw

Would it be possible to lint/format these?

@jacoblee93
Fix code sample in TS evaluation quickstart
e4750a7 
@hinthornw

Would it be possible to lint/format these?
@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langsmith-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 10:38pm

@jacoblee93
Copy link
Contributor Author

Actually, is

await runOnDataset(
  predictResult, // Your AI system
  datasetName, // The data to predict and grade over
  {
    evaluationConfig: {
      customEvaluators: [mustMention]
    }
  }
);

even the right syntax?

Isn't it now:

  await runOnDataset(ragChain, datasetName, {
    evaluators: [containsAResponse]
  })

@hinthornw
Copy link
Collaborator

oh maybe

bracesproul
bracesproul reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this solved with PR #187?

@agola11 agola11 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacoblee93 @hinthornw @bracesproul @agola11