Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding jina as scoring model. Feature request: #974 #1053

Merged
merged 6 commits into from
May 22, 2024

Conversation

One16-KS
Copy link
Contributor

@One16-KS One16-KS commented May 3, 2024

Module added according #973 in order to minimize conflicts. Implementation in line with cohere reranking

Issue

#974

Change

  • Adding Jina ai as a scoring model.
  • Default model: jina-reranker-v1-base-en
  • Default url: https://api.jina.ai/v1/
  • Used Jackson object mapper instead of Gson, as I found it it's langchain4j intent to move away from Gson
  • Tried to keep implementation in line with Cohere reranking module

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Module added according langchain4j#973 in order to minimize conflicts.
Implementation in line with cohere reranking
@One16-KS One16-KS marked this pull request as ready for review May 4, 2024 09:27
@One16-KS
Copy link
Contributor Author

One16-KS commented May 4, 2024

There is only an example of the reranking with cohere, but no separate documentation... I'm happy to have a small section on the reranking... Let me know what to do with it,
cheers

@One16-KS
Copy link
Contributor Author

Example not needed as there is already an advanced RAG example present with Cohere.

@langchain4j langchain4j added the P3 Medium priority label May 13, 2024
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@One16-KS good job, thanks a lot!

@langchain4j langchain4j merged commit 70d1b4a into langchain4j:main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants