Resolve Test Failures Post-Dev Merge #1672
Open
+1,158
−512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ (chat_io.spec.ts): refactor code to wait for modal to appear before clicking on the new project button ✨ (codeAreaModalComponent.spec.ts): refactor code to wait for modal to appear before clicking on the new project button, update code assertions ✨ (curl_api_generation.spec.ts): refactor code to wait for modal to appear before clicking on the new project button ✨ (dragAndDrop.spec.ts): refactor code to handle the case when generic node is not present ✨ (dropdownComponent.spec.ts): refactor code to wait for modal to appear before clicking on the new project button ✨ (filterEdge.spec.ts): add support for dynamic waiting for modal to appear before interacting with it 🐛 (filterEdge.spec.ts): remove redundant clicks on buttons and improve code readability ♻️ (filterEdge.spec.ts): refactor code to use loop instead of repetitive code for zooming out and waiting for timeout ✅ (filterEdge.spec.ts): update assertions to match changes in the application UI ✨ (floatComponent.spec.ts): refactor floatComponent test to use getByTitle instead of complex locators for button clicks ✨ (flowPage.spec.ts): refactor flowPage test to use getByTitle instead of complex locators for button clicks ✨ (group.spec.ts): refactor group test to use getByTestId instead of complex locators for button clicks and add loop to handle modal loading ✨ (inputComponent.spec.ts): refactor inputComponent test to use getByTitle instead of complex locators for button clicks ✨ (inputListComponent.spec.ts): add support for dynamic modal count to handle asynchronous modal loading 🐛 (inputListComponent.spec.ts): fix search query in inputListComponent test ♻️ (inputListComponent.spec.ts): refactor repetitive code for zooming out in inputListComponent test ✨ (intComponent.spec.ts): add support for dynamic modal count to handle asynchronous modal loading ♻️ (intComponent.spec.ts): refactor repetitive code for zooming out in intComponent test ✨ (keyPairListComponent.spec.ts): add support for dynamic modal count to handle modal loading delay ✨ (keyPairListComponent.spec.ts): update search input value to "amazon bedrock" for more accurate search results ✨ (keyPairListComponent.spec.ts): update node locator to "model_specsAmazon Bedrock" for more accurate node selection ✨ (keyPairListComponent.spec.ts): update zoom out action to use "zoom out" title for better readability ✨ (keyPairListComponent.spec.ts): update keypair verification locator to "editNodekeypair0" for more accurate verification ✨ (keyPairListComponent.spec.ts): update showcache checkbox locator to "showcache" for better readability ✨ (keyPairListComponent.spec.ts): update showcredentials_profile_name checkbox locator to "showcredentials_profile_name" for better readability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocator variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocatorNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocator variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocatorNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocator variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocatorNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocator variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocatorNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocator variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plusButtonLocatorNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementCountNode variable to handle nullability ✨ (keyPairListComponent.spec.ts): update keyPairVerification variable to handle nullability ✨ (keyPairListComponent.spec.ts): update elementKeyCount variable to handle nullability ✨ (keyPairListComponent.spec.ts): update plus ✨ (promptModalComponent.spec.ts): add support for dynamic modal count to handle asynchronous modal rendering ✨ (python_api_generation.spec.ts): add support for dynamic modal count to handle asynchronous modal rendering ✨ (saveComponents.spec.ts): add support for dynamic modal count to handle asynchronous modal rendering ✨ (store.spec.ts): add support for dynamic icon count to handle asynchronous rendering ✨ (textAreaModalComponent.spec.ts): add support for dynamic modal count to handle asynchronous modal rendering ✨ (toggleComponent.spec.ts): add support for dynamic waiting for modal to appear before interacting with it 🐛 (toggleComponent.spec.ts): fix typo in element locator for dataDirectory ♻️ (toggleComponent.spec.ts): refactor repetitive code for zooming out ✅ (toggleComponent.spec.ts): add assertions for checking toggle state and button clicks ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggleComponent.spec.ts): refactor repetitive code for toggling and checking toggle state ♻️ (toggle
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…le environment variable configuration 🔧 (frontend/playwright.config.ts): add dotenv configuration to read environment variables from .env file ♻️ (frontend/src/modals/IOModal/components/chatView/chatMessage/index.tsx): refactor code to add data-testid attribute to span element for sender name to improve testability ✅ (frontend/tests/end-to-end/chatInputOutput.spec.ts): add end-to-end test for user interaction with chat input/output functionality ✅ (frontend/tests/end-to-end/chat_io_teste.spec.ts): add end-to-end test for chat input/output functionality with file upload ✅ (chat_io.spec.ts): remove chat_io.spec.ts test file as it is no longer needed ✨ (textInputOutput.spec.ts): add new test file textInputOutput.spec.ts to test the functionality of text input and output components in the application
ogabrielluiz
requested changes
Apr 11, 2024
…related to Playwright browser binaries caching and installation 🔧 (typescript_test.yml): refactor setup of Python and Poetry versions to use a custom GitHub action for caching and setting up the environment efficiently
… functionality in the frontend ✨ (textInputOutput.spec.ts): rename test from "CodeAreaModalComponent" to "TextInputOutputComponent" to improve clarity and accuracy
…gflow into cz/fix-tests-dev
…tead of absolute path for better test portability 📝 (filterEdge.spec.ts): update test URL to use relative path instead of absolute path for better test portability 📝 (inputListComponent.spec.ts): update test URL to use relative path instead of absolute path for better test portability 📝 (store.spec.ts): update test URL to use relative path instead of absolute path for better test portability 📝 (textAreaModalComponent.spec.ts): update test URL to use relative path instead of absolute path for better test portability
…wright tests 🔧 (typescript_test.yml): configure uvicorn to use the langflow.main:create_app factory function, listen on all interfaces, use port 7860, enable auto-reload, read environment variables from .env file, and use asyncio event loop
… to correctly load environment variables
…correctly locate the file
…orn command to fix an issue with loading environment variables
…d a 2-second sleep to allow the server to start before running Playwright tests
…rove test performance 🐛 (chatInputOutput.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (codeAreaModalComponent.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (curl_api_generation.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (dragAndDrop.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (dropdownComponent.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (filterEdge.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (flowPage.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (globalVariables.spec.ts): handle potential error when counting modal titles to prevent test failures 🐛 (group.spec.ts): Fix bug in group and ungroup updating values test where modalCount was not correctly initialized 🐛 (inputComponent.spec.ts): Fix bug in InputComponent test where modalCount was not correctly initialized 🐛 (inputListComponent.spec.ts): Fix bug in InputListComponent test where modalCount was not correctly initialized 🐛 (intComponent.spec.ts): Fix bug in IntComponent test where modalCount was not correctly initialized 🐛 (keyPairListComponent.spec.ts): Fix bug in KeypairListComponent test where modalCount was not correctly initialized 🐛 (langflowShortcuts.spec.ts): Fix bug in LangflowShortcuts test where modalCount was not correctly initialized 🐛 (nestedComponent.spec.ts): Fix bug in NestedComponent test where modalCount was not correctly initialized 🐛 (promptModalComponent.spec.ts): Fix bug in PromptTemplateComponent test where modalCount was not correctly initialized 🐛 (python_api_generation.spec.ts): Fix bug in python_api_generation test where modalCount was not correctly initialized 🐛 (saveComponents.spec.ts): Fix bug in save group component tests where modalCount was not correctly initialized 🐛 (textAreaModalComponent.spec.ts): Fix bug in TextAreaModalComponent test where modalCount was not correctly initialized ✅ (textInputOutput.spec.ts): handle error when getting modal title element and set modalCount to 0 in case of error ✅ (toggleComponent.spec.ts): handle error when getting modal title element and set modalCount to 0 in case of error ✅ (tweaks_test.spec.ts): handle error when getting modal title element and set modalCount to 0 in case of error
… 5 to reduce resource usage and improve test stability
…id parallel tests on CI 📝 (playwright.config.ts): comment out the workers configuration and add a new line with a single worker to clarify the intention ✨ (playwright.config.ts): add a new file "temp" to the frontend directory
…ables from .env file for local development and CI/CD environments 📝 (textInputOutput.spec.ts): add support for loading environment variables from .env file for local development and CI/CD environments
… with secret environment variables 🚀 (typescript_test.yml): run Playwright tests after creating .env file to ensure tests have access to necessary environment variables
… the "Close" button
…ard index and total for distributed test execution ♻️ (playwright.config.ts): refactor workers configuration to use environment variable CI to determine the number of workers for parallel tests
…oid parallel tests on CI environment
…headlessui-disclosure-button-:rld:' ♻️ (filterEdge.spec.ts): remove redundant assertions for elements with ids 'saved_componentsBasic RAG' and 'saved_componentsGroup' ♻️ (floatComponent.spec.ts): refactor code to handle modal dynamically by checking for modal title element and waiting for it to appear before clicking on 'new-project-btn' element
…on CI to improve test parallelization 🐛 (filterEdge.spec.ts): add a 2-second delay before asserting visibility of tooltips to ensure they are fully rendered before checking visibility
… easier testing and querying 📝 (index.tsx): add data-testid attribute to the public checkbox for easier testing and querying 📝 (test_file.txt): add a test file for end-to-end testing purposes 📝 (fileUploadComponent.spec.ts): add end-to-end test for file upload functionality ✨ (flowSettings.spec.ts): add end-to-end test for flow settings functionality ✨ (store.spec.ts): add end-to-end test for sharing a component with the share button
…ecution and improve stability 📝 (test_file.txt): remove newline at the end of the file for consistency ♻️ (flowPage.spec.ts): refactor code to remove unnecessary lines and commented out code ♻️ (flowSettings.spec.ts): refactor code to generate a random flow name instead of hardcoding it
…rom the 'npx playwright test' command to simplify the command and remove unnecessary complexity 🐛 (textInputOutput.spec.ts): change 'textContent()' to 'inputValue()' to correctly retrieve the value of the input field
…y matrix configuration for shardIndex and shardTotal ✅ (typescript_test.yml): update test workflow to run tests on a single shard instead of multiple shards for simplicity and efficiency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues encountered with failing tests following the merge into the development branch. The changes implemented here aim to rectify these failures, ensuring the stability and accuracy of our testing suite.
Key Changes:
Identified and resolved inconsistencies causing test failures.
Adjusted test cases to align with recent changes in the development branch.
Conducted thorough testing to validate the effectiveness of the fixes.
These adjustments are crucial for maintaining the integrity of our codebase and ensuring a smooth development process. All relevant tests have been re-run to verify the successful resolution of the issues.