Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better implementation of the Ollama component #1701

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

yamonkjd
Copy link
Contributor

A draft to synchronize the model using the latest Langflow architecture and to improve it according to the latest Langchain specifications.

A draft to synchronize the model using the latest Langflow architecture and to improve it according to the latest Langchain specifications.
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:52am

Checkout Models from api
@ogabrielluiz
Copy link
Contributor

Hey @yamonkjd
How are you?

Thanks for all the help.

We'd love to get Ollama to an awesome level. Do you plan on having this ready soon? I could take a crack at it if you are swamped today.

@yamonkjd
Copy link
Contributor Author

Hey @yamonkjd How are you?

Thanks for all the help.

We'd love to get Ollama to an awesome level. Do you plan on having this ready soon? I could take a crack at it if you are swamped today.

Hello,

The testing for Ollama's Keepalive was not normal, so we are still working on it.

We will complete it and reach out to you within today.

@yamonkjd yamonkjd marked this pull request as ready for review May 13, 2024 07:59
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels May 13, 2024
@yamonkjd
Copy link
Contributor Author

I removed the callback element as it seems it will be replaced with Langflow's management methods. I also removed caching as its operation was not guaranteed (I think this will likely be integrated into Langflow as well).
Before the request, I performed Make lint and confirmed that there are no conflicts.

However, since it is not the initially written version, it seems there is an error from Langflow itself (Openapi key).
It seems there are no problems in the main code, and there have been many requests, so I request a merge.

@yamonkjd
Copy link
Contributor Author

This proposal was simply made because we need it. If there is a better implementation, it can be discarded or used simply for reference. We have also been considering implementing interaction features using Ollama's API, which would allow us to add models directly or specify model files ourselves (such as selecting a model from Ollama's official model list and installing it on an instance).

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we merge it?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants