Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update milvus-standalone-docker-compose.yml #3721

Closed
wants to merge 1 commit into from

Conversation

tibbon
Copy link

@tibbon tibbon commented Apr 23, 2024

Description

because: 2.4.0 is the newest version, as of 6 days ago.

this commit: bumps the version of milvusdb/milvus

Fix #3762

Type of Change

Please delete options that are not relevant.

  • Dependency upgrade

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

because: 2.4.0 is the newest version, as of 6 days ago. 

this commit: bumps the version of milvusdb/milvus
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Apr 23, 2024
@bowenliang123
Copy link
Contributor

-1 for bumping Milvus version solely.

According to pymilvus doc( https://github.com/milvus-io/pymilvus?tab=readme-ov-file#compatibility), Milvus 2.4.x requires pymilvus 2.4.x.

And I strongly suggested merging #3688 first for unit tests on vector stores running from docker compose file.

@takatost
Copy link
Collaborator

Milvus 2.4 brought some breaking changes, please refer to #3795.

@tibbon
Copy link
Author

tibbon commented Apr 25, 2024

Thanks for that feedback; seems 2.4 isn't the move for now. Closing accordingly.

@tibbon tibbon closed this Apr 25, 2024
@tibbon tibbon deleted the patch-1 branch April 25, 2024 15:19
@bowenliang123
Copy link
Contributor

bowenliang123 commented Apr 26, 2024

@tibbon Thanks for your understanding and kindness. My original intention of raising #3795 is not to replace your PR here, but just for that I'm introducing integration tests for vdb stores recently in #3688.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the version of pymilvus in docker image v0.6.4 is wrong.
3 participants