Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vector db pgvector #3879

Merged
merged 12 commits into from May 10, 2024
Merged

Conversation

vaayne
Copy link
Contributor

@vaayne vaayne commented Apr 26, 2024

Description

Support pgvector a new type of vector database.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local integration tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Apr 26, 2024
@vaayne vaayne changed the base branch from deploy/dev to main April 26, 2024 07:27
@JohnJyong JohnJyong self-requested a review April 26, 2024 11:35
@JohnJyong
Copy link
Contributor

hi @vaayne , pls add the integration_tests for the pgvector in the folder 'tests.integration_tests.vdb', thanks

@vaayne vaayne force-pushed the feat/vector_db_pgvector branch 2 times, most recently from a035970 to b378adf Compare April 27, 2024 02:30
@vaayne
Copy link
Contributor Author

vaayne commented Apr 27, 2024

all done @JohnJyong

@JohnJyong
Copy link
Contributor

This branch has conflicts that must be resolved @vaayne

@JohnJyong
Copy link
Contributor

our db is using the postgresql , the pgvector is using the same volumes path and port with it , it's better to set another folder path and port for pgvector , thanks @vaayne

@vaayne
Copy link
Contributor Author

vaayne commented Apr 29, 2024

All done @JohnJyong

@vaayne
Copy link
Contributor Author

vaayne commented May 6, 2024

@JohnJyong Do you have time to review this PR, Thanks

@vaayne vaayne requested a review from JohnJyong May 10, 2024 01:50
@JohnJyong
Copy link
Contributor

LGTM , thanks for your contribution @vaayne

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2024
@JohnJyong JohnJyong merged commit 875249e into langgenius:main May 10, 2024
7 checks passed
@takatost takatost mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants