Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send linting hints to comment when style check fails #3881

Closed
wants to merge 8 commits into from

Conversation

bowenliang123
Copy link
Contributor

Description

  • send linting hits to PR's comment when Ruff check fails

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@bowenliang123 bowenliang123 marked this pull request as draft April 26, 2024 07:47
@dosubot dosubot bot added the 💪 enhancement New feature or request label Apr 26, 2024
@bowenliang123 bowenliang123 changed the title add lint comment send linting hints to comment when style check fails Apr 26, 2024
@bowenliang123
Copy link
Contributor Author

Resource not accessible by integration error when sending comment to the PR, due to lack of write permission in Github workflow actions.

Run actions/github-script@v7
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:9537:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  status: 403,

Docs for enabling or managing Github workflow permissions:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-the-default-github_token-permissions

@bowenliang123
Copy link
Contributor Author

cc @crazywoola @takatost

@bowenliang123 bowenliang123 marked this pull request as ready for review April 28, 2024 13:44
@bowenliang123 bowenliang123 marked this pull request as draft May 9, 2024 15:53
@bowenliang123 bowenliang123 deleted the lint-comment branch May 17, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant