Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add avg rag delay time monitoring curve #3901

Closed
wants to merge 82 commits into from

Conversation

charli117
Copy link
Contributor

@charli117 charli117 commented Apr 26, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

luowei and others added 30 commits October 24, 2023 22:32
# Conflicts:
#	web/i18n/lang/app-overview.zh.ts
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 26, 2024
@JohnJyong JohnJyong self-requested a review April 26, 2024 12:36
@JohnJyong
Copy link
Contributor

for python code, LGTM

@takatost
Copy link
Collaborator

This might be more suitable to showcase in the knowledge base.
@VincePotato what do you think about this?

@charli117
Copy link
Contributor Author

This might be more suitable to showcase in the knowledge base. @VincePotato what do you think about this?

I want put to knowledge base, but knowledge doesn't have dashboard

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 7, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 7, 2024
@VincePotato
Copy link

This metric really seems like it should go in the RAG. We'll consider the design of monitoring metrics after we've restructured the RAG.

@VincePotato VincePotato closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants