Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for local ai speech to text #3921

Merged
merged 5 commits into from May 7, 2024
Merged

Add support for local ai speech to text #3921

merged 5 commits into from May 7, 2024

Conversation

Tomywang999
Copy link
Contributor

@Tomywang999 Tomywang999 commented Apr 27, 2024 •
edited

Description

Add support for local AI speech-to-text.

Type of Change

  • New feature (non-breaking change which adds functionality)

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime 💪 enhancement New feature or request labels Apr 27, 2024
takatost
takatost requested changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/tests/integration_tests/model_runtime/localai
Please add integration testing code so we can easily test if the features are working properly.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@Tomywang999
Copy link
Contributor Author

Tomywang999 commented Apr 29, 2024 •
edited

test file being passed, the local test being passed

Yeuoly
Yeuoly approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 7, 2024
@Yeuoly Yeuoly merged commit bb7c627 into langgenius:main May 7, 2024
7 checks passed
rennokki pushed a commit to rennokki/dify that referenced this pull request May 9, 2024
@Tomywang999 @Yeuoly @rennokki
Add support for local ai speech to text (langgenius#3921)
cc4fab2 
Co-authored-by: Yeuoly <admin@srmxy.cn>
@takatost takatost mentioned this pull request May 9, 2024
Merged
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
@Tomywang999 @Yeuoly @evnydd0sf
Add support for local ai speech to text (langgenius#3921)
9a4a0d1 
Co-authored-by: Yeuoly <admin@srmxy.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost requested changes

@Yeuoly Yeuoly Yeuoly approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request ⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tomywang999 @takatost @Yeuoly