Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: combine and send ci coverage report to PR comment #3957

Closed
wants to merge 9 commits into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Apr 28, 2024

Description

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@bowenliang123
Copy link
Contributor Author

The error HttpError: Resource not accessible by integration is due to lack of write permission for workflow actions.

Docs for enabling or managing Github workflow permissions:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-the-default-github_token-permissions

@bowenliang123 bowenliang123 marked this pull request as ready for review April 28, 2024 13:44
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Apr 28, 2024
@bowenliang123
Copy link
Contributor Author

cc @crazywoola

@LeoQuote

This comment was marked as off-topic.

@bowenliang123
Copy link
Contributor Author

Please consider using codecov instead of inventing wheel again

This PR is not inventing the wheel again, but generally reused the pytest framework and coverage outputs. And it's not introducing outside dependencies or cost.

codecov, as you mentioned, is an outside platform instead, which could have lead to further constraint or possible fee to the Dify project itself.

If Dify project decide to connect to third-party platform like codecov. I would like to follow.

@LeoQuote

This comment was marked as off-topic.

@bowenliang123
Copy link
Contributor Author

bowenliang123 commented May 8, 2024

Why are you so aggressive in your sords to the goal while ignoring the key points I just mentioned about the balance of third-party platform constraint and the feasibility? Is that codedev the only and the so-called somehow best software for testing coverage in your mind ? It's even far from free or non-profit service itself to the Dify itself as the open-source and business project !

@LeoQuote

This comment was marked as off-topic.

@bowenliang123
Copy link
Contributor Author

bowenliang123 commented May 8, 2024

PLEASE at least respect the Dify project and the Dify community behaviour code.
I raised this PR with proper explanation and implementation for mutual benefit.
If you have a better solution, PLEASE submit yours.
STOP over-criticize other's proposals with no solid approaches or supporting discussions.

@bowenliang123 bowenliang123 deleted the ci-coverage branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants