feat: Use Romanian & other languages in QA embedding #4047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added prompt_name for langs
dosubot
bot
added
the
size:M
rennokki
changed the title
dosubot
bot
added
☕️ typescript
rennokki
commented
May 2, 2024
| @@ -312,6 +312,7 @@ export const useLanguages = () => { | |||
| cs: t(`${langPrefix}cs`), | |||
| th: t(`${langPrefix}th`), | |||
| id: t(`${langPrefix}id`), | |||
| ro: t(`${langPrefix}ro`), | |||
There was a problem hiding this comment.
Not sure if this is relevant, just came across this.
web/i18n/language.ts
Outdated
| example: 'Hello, Dify!', | ||
| supported: true, | ||
| }, | ||
| { | ||
| value: 'zh-Hans', | ||
| name: '简体中文', | ||
| prompt_name: 'Chinese', |
There was a problem hiding this comment.
Not sure if both should be Chinese. I think this is the Simplified one and the other is Traditional?
…Dify's Japanese README (langgenius#4075) Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: rongjun.qiu <qiurj@hengtonggroup.com.cn>
Co-authored-by: baxiang <baxiang@lixiang.com>
Co-authored-by: owen <owen@owen.hawk-toad.ts.net>
Co-authored-by: luowei <glpat-EjySCyNjWiLqAED-YmwM> Co-authored-by: crazywoola <427733928@qq.com> Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: Yeuoly <admin@srmxy.cn>
Co-authored-by: Yeuoly <admin@srmxy.cn>
…ggenius#4110) Co-authored-by: Gimling <huangjl@ruyi.ai> Co-authored-by: takatost <takatost@gmail.com>
Added prompt_name for langs
dosubot
bot
added
size:XL
|
I fudged it up. :) |
|
Messing up this PR. New one: #4205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw there is jut Chinese & English when creating Q&A embeddings. I have added all the languages that exist, plus the Romanian language.
Since the prompt is English and mentions
{language}, it was relevant enough to just add a newprompt_namethat may be used to infer the language in any prompt.Fixes # (issue) — N/A
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
N/A
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes