Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: z-index #4065

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: z-index #4065

wants to merge 2 commits into from

Conversation

ZuzooVn
Copy link

@ZuzooVn ZuzooVn commented May 3, 2024

Description

Fix the z-index bug
Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Before:

Screenshot 2024-05-03 at 7 16 47 PM

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels May 3, 2024
@ZuzooVn ZuzooVn changed the title Fix z index fix: z-index May 3, 2024
@takatost takatost requested a review from iamjoel May 4, 2024 05:49
@ZuzooVn
Copy link
Author

ZuzooVn commented May 15, 2024

@iamjoel is it ok?

@iamjoel
Copy link
Collaborator

iamjoel commented May 16, 2024

@iamjoel is it ok?

z-index is ok. Others is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants