Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support azure via -m flag #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support azure via -m flag #419

wants to merge 1 commit into from

Conversation

Mohannadcse
Copy link
Collaborator

Azure can be provided using the flag -m without the need to make modifications to thellm_config. Here is an example python3.11 examples/basic/chat.py -m azure

@Mohannadcse
Copy link
Collaborator Author

@pchalasani I'll fix the linting issue if there are no concerns about the current implementation

@pchalasani
Copy link
Contributor

@Mohannadcse let's revisit this later. There may be a way to have it create an AzureGPT instance based on type.

Copy link
Contributor

@pchalasani pchalasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a better way. I don't want to bring in vbls specific to AzureGPTConfig subclass into OpenAIGPTConfig

@Mohannadcse
Copy link
Collaborator Author

I don't want to bring in vbls specific to AzureGPTConfig subclass into OpenAIGPTConfig

agreed, but we can make it as a tmp solution, till we figure out a better way.

@Mohannadcse
Copy link
Collaborator Author

or we can move these variables to the OpenAIGPTConfig and remove them from AzureGPTConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants