Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic title #2741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add dynamic title #2741

wants to merge 1 commit into from

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Nov 1, 2023

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@dzhou121
Copy link
Collaborator

dzhou121 commented Nov 1, 2023

It's already setting title like this
https://github.com/lapce/lapce/blob/master/lapce-app/src/app.rs#L3284

@panekj
Copy link
Collaborator Author

panekj commented Nov 1, 2023

It's already setting title like this master/lapce-app/src/app.rs#L3284

But this just works for workspace?

@dzhou121
Copy link
Collaborator

dzhou121 commented Nov 1, 2023

It defaults to Lapce if no workspace is open.

@panekj
Copy link
Collaborator Author

panekj commented Nov 1, 2023

I don't mean whether it's working with just workspace, this will update the title only for workspace change

@dzhou121
Copy link
Collaborator

dzhou121 commented Nov 1, 2023

oh you added editor tab to the title. sorry my bad.

I would prefer it to use .window_title on the window_tab view, so that whenever the active editor tab is changed, it will be updated.

@panekj
Copy link
Collaborator Author

panekj commented Nov 1, 2023

Should it be attached on window_tab and not editor_tab?

@dzhou121
Copy link
Collaborator

dzhou121 commented Nov 1, 2023

Yeah on window_tab as you can get the active editor tab there.

@dzhou121
Copy link
Collaborator

dzhou121 commented Nov 1, 2023

Actually you can just do it here

https://github.com/lapce/lapce/blob/master/lapce-app/src/app.rs#L3284

Get the active editor tab from window_tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants