-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Improves errors #51261
[11.x] Improves errors #51261
Conversation
src/Illuminate/Foundation/resources/exceptions/renderer/components/card.blade.php
Show resolved
Hide resolved
$events->listen(QueryExecuted::class, [$this, 'onQueryExecuted']); | ||
|
||
if (isset($_SERVER['LARAVEL_OCTANE'])) { | ||
$events->listen([RequestReceived::class, TaskReceived::class, TickReceived::class, RequestTerminated::class], function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nunomaduro does this need to also reset on any job events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replicated what ignition is doing: https://github.com/spatie/laravel-ignition/blob/9c60d929a91803dee7e47614c37cbe6d3f2b1e2c/src/IgnitionServiceProvider.php#L311C1-L311C43.
@nunomaduro I think this is good pending those weird HTML formatting things I pointed out and single comment above. |
src/Illuminate/Foundation/Providers/FoundationServiceProvider.php
Outdated
Show resolved
Hide resolved
This reverts commit 4598691.
4e1409e
to
130e6eb
Compare
No description provided.