FIX : fixed the mesh operator logo bg low opacity in dark mode. #5427
Conversation
Signed-off-by: hunx <junaidhunain6@gmail.com>
|
🚀 Preview for commit 3afa63b at: https://65e0de80d8f3371e521f9a05--layer5.netlify.app |
|
@vishalvivekm kindly review the changes. |
There was a problem hiding this comment.
Thanks!
However, this doesn't fully solve the issue. See screenshot from https://65e0de80d8f3371e521f9a05--layer5.netlify.app/cloud-native-management/meshery/operating-service-meshes
@hunxjunedo, please know that this is the Meshery Operator version for dark mode, which is available in the layer5.io/brand page.
|
@VictoryWekwa perhaps, we can do better than this for the dark mode version of the Meshery Operator... |
|
Ok so I am changing the logo to properly transparent as it is on the brands page. |
|
@hunxjunedo Let's discuss this on Websites's call today 6:30 PM IST. Let's add this as an agenda item into the meeting minutes |
|
@vishalvivekm hey sorry I couldn't make it, was busy the whole time. |
|
@hunxjunedo hey are u still working on it? |
|
@iArchitSharma yes, creating a pull request this weekend. |
|
@iArchitSharma hey unfortunately im encountering some issues with my system, you can proceed if you want to. |
|
@vishalvivekm @jameshorton2337 I was busy for a while. Has there been any progress regarding this issue or should I resolve this as suggested? |
|
@hunxjunedo Thanks for the concern ,its already fixed |
Description
This PR fixes #5424. I have introduced new variables in the themes file which are specifically for defining the bg color of mesh operator logo. The logo container also takes the bg from this variable now.
Notes for Reviewers
Signed commits