Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Images in Chaos Mesh Integration under How it Works See in Action Section #5440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated Images in Chaos Mesh Integration under How it Works See in Action Section #5440

wants to merge 2 commits into from

Conversation

Chay2203
Copy link
Contributor

@Chay2203 Chay2203 commented Mar 4, 2024 •
edited

Description

This PR fixes #4867

Notes for Reviewers
I have updated images in the How It Works See in Action Section under Chaos Mesh Integration, please review the changes and merge the PR :D

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Mar 4, 2024

🚀 Preview for commit 95ee723 at: https://65e5b448578de00f43e12e2b--layer5.netlify.app

@Chay2203
Updated Images in Chaos Mesh Integration under How it Works See in Ac…
7d43a59 
…tion Section

Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
@Chay2203
Updated the Images with correct Dark Mode
bab4241 
Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Mar 6, 2024

🚀 Preview for commit bab4241 at: https://65e89fd9f661f11f7246a2e9--layer5.netlify.app

@Chay2203
Copy link
Contributor Author

Chay2203 commented Mar 6, 2024

Hey @leecalcote, I have made the necessary changes that we have discussed in the GMeet, please have a look now :)

@vishalvivekm
Copy link
Member

Hey @leecalcote, I have made the necessary changes that we have discussed in the GMeet, please have a look now :)

@Chay2203 aren't you using the same screenshots as in https://github.com/layer5io/layer5/pull/5437/files ?
A update might be required here; screenshots specifically showing how Chaos Mesh integrates with Meshery.

@Chay2203
Copy link
Contributor Author

Sure @vishalvivekm, will make the changes accordingly :)

@iArchitSharma
Copy link
Contributor

@Chay2203 you still working on this?

@Chay2203
Copy link
Contributor Author

@iArchitSharma yes, will complete it by tomorrow :)

@leecalcote
Copy link
Member

👀

@sudhanshutech
Copy link
Member

@Chay2203 are you still here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iArchitSharma iArchitSharma Awaiting requested review from iArchitSharma

Assignees
No one assigned
Labels
project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] Chaos Mesh under 'How it Works See It in Action' section
6 participants
@Chay2203 @l5io @vishalvivekm @iArchitSharma @leecalcote @sudhanshutech