Small LineChart improvements: Allow invalid Y values, fix Line.setXXX() #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setSquare(false) no longer resets cubic mode
cubic lines this does not yet work.
moritzboth
changed the title
|
Hi, thanks, let me look at that:) |
|
Hello @lecho any chances to get this in soon on a new version :) ? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I changed LineChart so you can add Float.NaN Y values for line interruptions (invalid values). So far this works for the regular and square lines only (all I need). Cubic is to be done.
Also, Line.setCubic(false) and Line.setSquare(false) would reset the respective other setting to false which is not expected. Even worse, Line.setSquare(true) would result in a regular line if Line.setCubic(true) was called before and vice versa.
This is my first pull request on github. I wondered if it made sense to separate those two unrelated concerns into two pull requests but could not find an obvious way to do so. In case I did something stupid please bear with me :)
moritz