Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verisons of sqlite3 and activerecord #468

Merged
merged 1 commit into from May 13, 2024
Merged

Fix verisons of sqlite3 and activerecord #468

merged 1 commit into from May 13, 2024

Conversation

ajdubovoy
Copy link
Contributor

@ajdubovoy
Copy link
Contributor Author

@Eschults Ok if I merge this as well?

@Eschults Eschults merged commit ef58ab1 into master May 13, 2024
@Eschults
Copy link
Member

Sure, let's make sure we revert the change as soon as the issue w/ M1 is solved 👌

@Eschults Eschults deleted the ajdubovoy/sqlite-version branch May 13, 2024 13:27
@ajdubovoy
Copy link
Contributor Author

So it's actually not an issue with M1 but rather that the latest version of SQLite3 is incompatible with ActiveRecord. We can wait till they both upgrade, but also given that every single past upgrade to SQLite3 and ActiveRecord has broken our setup, is there any disadvantage to leaving the versions fixed and upgrading the fixed versions when we're sure they're compatible?

@Eschults
Copy link
Member

Yes it's fine, as long as we have an issue on our radar to remind us to unlock versions when the problem is solved, otherwise the risk is to fall behind and teach old versions to our students 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajdubovoy @Eschults