Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache): resend alter queue support #2855

Merged
merged 5 commits into from
May 20, 2024
Merged

feat(cache): resend alter queue support #2855

merged 5 commits into from
May 20, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@ngjaying
feat(sink): set the retry interval
720a21d 
will resend once if retry interval is set

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
feat(op): add cache length metrics
a76cc14 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
feat(planner): support resend alter queue
3c08fb5 
1. Topo/Sink node supports setting alter queue
2. Planner weave two kinds of topo for linear cache and resend cache
3. Refactor broadcast to allow customize

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 79.81651% with 22 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master-v2@f89aa77). Learn more about missing BASE report.

Files Patch % Lines
internal/topo/planner/planner_sink.go 55.56% 8 Missing and 4 partials ⚠️
internal/io/mqtt/connection.go 58.33% 2 Missing and 3 partials ⚠️
internal/topo/node/sink_node.go 88.64% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master-v2    #2855   +/-   ##
============================================
  Coverage             ?   68.75%           
============================================
  Files                ?      272           
  Lines                ?    25785           
  Branches             ?        0           
============================================
  Hits                 ?    17728           
  Misses               ?     6470           
  Partials             ?     1587

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying
fix(mqtt): publish should fail if conn lost
ec4f853 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review May 17, 2024 07:19
@ngjaying
test(sink): add sink node retry tests
fdb78ee 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying requested a review from Yisaer May 17, 2024 08:01
@ngjaying ngjaying merged commit 7c9560d into lf-edge:master-v2 May 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ngjaying @Yisaer