fix and enable load_nameservers_from_registry() fallback #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdns_nameserver_ip_add_line() should return an error if an empty string is passed, so load_nameservers_from_registry() gets called if load_nameservers_with_getnetworkparams() cannot find any nameserver. load_nameservers_from_registry() needs to: - iterate over interfaces - check for STATUS_SUCESS when fetching the size of the registry entry - use ascii variant of the lookup function since result is used as a string - null-terminate the retrieved registry value - release key handles on error
azat
reviewed
Mar 3, 2024
|
I have not checked yet, as this function is not public to the outside. Am 03.03.2024 um 14:14 schrieb Azat Khuzhin ***@***.***>:
@azat commented on this pull request.
Thank you! Is it possible to write a test?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
It can be exposed via private header ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evdns_nameserver_ip_add_line() should return an error if an empty string is passed, so load_nameservers_from_registry() gets called if load_nameservers_with_getnetworkparams() cannot find any nameserver.
load_nameservers_from_registry() needs to: