gcc: fix some compiler errors from the new GCC #1658
Conversation
panjf2000
changed the title
panjf2000
changed the title
|
I think we may want to cancel those outdated CI jobs for this PR manually to make room for the latest one. @azat |
|
New failure arose, caused by Bug 106416 - -Wint-conversion should be an error, not a pedwarn |
panjf2000
changed the title
panjf2000
force-pushed
the
win-keepalive
branch
2 times, most recently
from
0b674f0
to
79d764e
Compare
|
Still something wrong |
Yes, with -Wincompatible-pointer-types and -Wint-conversion being turned into error level on MinGW somehow, lots of code in |
|
It should be pretty easy to fix, there is another option - turn off those warning for mingw build, but I don't like this idea |
panjf2000
changed the title
|
Finally, all new compiler errors are fixed! https://github.com/libevent/libevent/actions/runs/9168188585/job/25206570042?pr=1658 I think we're good to go. |
|
Ping @azat |
--------- Signed-off-by: Andy Pan <i@andypan.me>
--------- Signed-off-by: Andy Pan <i@andypan.me>
--------- Signed-off-by: Andy Pan <i@andypan.me>
--------- Signed-off-by: Andy Pan <i@andypan.me>
|
Thank you! Now LGTM (will merge once mingw build will pass) |
New compiler errors to be fixed:
[-Wincompatible-pointer-types],[-Wint-conversion], and[-Wcast-function-type]The CI failure for -Wincompatible-pointer-types may have something to do with this GCC patch. See also this llvm/llvm-project#74605.
Thus, I think we should explicitly cast the
intpointer to the expected type to avoid these compiler errors.@azat