Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CMake build to compile in C++17 mode if available #3590

Merged
merged 2 commits into from
May 21, 2024

Conversation

johnplatts
Copy link
Contributor

Updated CMakeLists.txt to build libjxl in C++17 mode if supported by the C++ compiler.

For optimal dynamic dispatch with Google Highway, Clang 5 or later, GCC 7 or later, or MSVC 19.16 or later is needed, and all of these compilers have support for the C++17 standard.

Also added workarounds to suppress any -Wdeprecated-declarations warning that might be emitted by std::stable_sort with GCC or Clang in C++17 mode due to the libstdc++ implementation of std::stable_sort using std::get_temporary_buffer, which has been deprecated in C++17.

Copy link
Contributor

@eustas eustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also file an issue to get rid of stable_sort at some moment.

Thanks.

@eustas eustas enabled auto-merge May 21, 2024 09:39
@eustas eustas added this pull request to the merge queue May 21, 2024
Merged via the queue into libjxl:main with commit 4451ce9 May 21, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants