Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the user actions in a dropdown window with labels #15260

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Paul-Etienne
Copy link
Contributor

@Paul-Etienne Paul-Etienne commented May 8, 2024

This is built on top of @awestm 's PR regarding issue #13991.
It places the action buttons rack inside of a dropdown window as done originally by awestm, for both desktop and mobile, as I figured even desktop would benefit from this redesign. The original problem was that these buttons are very confusing without hovering over them, and displaying the full text next to the icon is the most efficient way to get that information.
But since showing the text for all of the buttons takes too muhc space even on desktop, the best thing to do (in my opinion) is use the dropdown for all situations.
I would post screenshots but somehow I've broken my local environment and don't have time to set it back up right now.

I placed the dropdown button on the same line as the user's name as it makes more sense now, since it's related to the user's profile. I also fixed the opacity and font-size for the "last active since" text. The opacity would cause this text to overlap the dropdown window (and was looking odd there to be honest, being slightly transparent and smaller than the beginning of the sentence).

@ornicar
Copy link
Collaborator

ornicar commented May 9, 2024

Interesting, but from a quick try there seems to be issues atm

140x743_2024-05-09
337x863_2024-05-09

@Paul-Etienne
Copy link
Contributor Author

Thanks for pointing that out, I'll check that when I have time

@Paul-Etienne Paul-Etienne force-pushed the feat/13991/improve-user-actions-ui branch from 89b2ddb to 57ec0e6 Compare May 15, 2024 22:07
@Paul-Etienne Paul-Etienne reopened this May 15, 2024
@Paul-Etienne
Copy link
Contributor Author

Paul-Etienne commented May 15, 2024

Alright, I believe I've fixed the issues you reported @ornicar. I had only tested on the user's own profile 🤦‍♂️
I've put the dropdown menu on the second line again, I didn't think there could be other ui components at this location.
But there's still some gray area, I see code in def mini() in RelationUi.scala that would probably break because of the remaining btn-rack classes, but I'm not sure where it's called exactly.

@Paul-Etienne
Copy link
Contributor Author

Paul-Etienne commented May 19, 2024

Do you see other things that need to be addressed in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants