-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize ui/learn #15263
Merged
Merged
Modernize ui/learn #15263
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
e4cc0d8
implement snabbdom skeleton
brollin 928d360
map view wip
brollin 614a002
implement map ribbons
brollin b7f0d39
implement map what next section
brollin b70a599
implement mapSideView
brollin bd43dde
implement isStageIdComplete
brollin 623ee99
simple hash routing logic
brollin 9f90297
inStage logic fixup
brollin 4d58a40
run controller/view wip
brollin 29ce7b0
implement run controller wip
brollin 531d2a6
fix top level dom hierarchy
brollin e31b572
migrate many things away from mithril
brollin 69565e8
implement level controller
brollin 47bbede
run view renders
brollin bad5a35
fix line breaks and images
brollin 39fdf26
fix hash linking
brollin 91b1e2a
banish all traces of mithril
brollin 7bb4b3f
basic chessground implementation wip
brollin ee686c1
update chessground wip
brollin 0cb1914
Merge remote-tracking branch 'upstream/master' into modernize-learn
brollin 72d75a4
lock file updates after master merge
brollin a7bab09
setup chessground with blueprint
brollin 20ccf1b
fix click handlers
brollin a23bf79
clean up chessground code a little
brollin 4bf7c93
simplify run controller
brollin 0334360
implement level controller cg
brollin fcfa6de
remove v2 directory
brollin 32df5af
fix import paths
brollin 78dba36
implement hashNavigate
brollin 2f17995
implement storage xhr
brollin 7e190dd
fix star icon
brollin 400bf2f
fixups
brollin d87b047
chessground tweaks
brollin 3a9e091
implement scenario controller
brollin 522c79b
refactor to use withGround pattern
brollin 103c47f
implement promotion controller and view
brollin cbb8fb5
fix promotion overlay
brollin d2e1a41
separate sendMove from initialization
brollin 05f885c
keep side view category id in sync with stage
brollin b47d6ae
stage complete ui
brollin 5d54403
stage starting ui rerender fix
brollin c666a59
fix level resume calculation
brollin c6e8cac
improve restart flow
brollin 6d2dd04
reimplement piece wriggle
brollin 42c51c1
move final ground bits into chessground.ts
brollin 5ca399b
refactor showCheckmate and setCheck
brollin 7599fdc
refactor chess controller
brollin 0b24813
update todos
brollin 250a97e
fix map side view category clicking
brollin 5010886
items refactor wip
brollin 0f5472e
various small fixups
brollin f57007b
implement apples as custom svgs wip
brollin a2cc379
fix stage id calculation
brollin 4d5ceb6
wip
brollin 39e20ca
black pawn background-image approach partial implementation
brollin 6604c3b
custom svgs implementation
brollin bdf6d34
fix shapes race condition
brollin f614db0
give attribution for SVG
brollin aca61bb
manual context menu fix
brollin ec619e4
Merge branch 'master' into modernize-learn
ornicar 6694cb7
ui/learn apple const svg
ornicar b2af3e9
use latest chessground
ornicar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit out of place here, maybe only because it is in a typescript file and not in the public folder. Not sure if there is a better place though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it is public domain, so maybe not even needed, but feels nice to do