Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint errors (false positives) #822

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix pylint errors (false positives) #822

merged 1 commit into from
May 21, 2024

Conversation

mgedmin
Copy link
Contributor

@mgedmin mgedmin commented May 20, 2024

The errors were

************* Module linkcheck.ansicolor
linkcheck/ansicolor.py:190:21: E0606: Possibly using variable 'WinColor' before assignment (possibly-used-before-assignment)
************* Module linkcheck.plugins.locationinfo
linkcheck/plugins/locationinfo.py:107:12: E0606: Possibly using variable 'geoip_error' before assignment (possibly-used-before-assignment)

and while it's true that the variables (WinColor, geoip_error) are assigned conditionally, their use is protected (indirectly) by the same conditionals.

The errors were

    ************* Module linkcheck.ansicolor
    linkcheck/ansicolor.py:190:21: E0606: Possibly using variable 'WinColor' before assignment (possibly-used-before-assignment)
    ************* Module linkcheck.plugins.locationinfo
    linkcheck/plugins/locationinfo.py:107:12: E0606: Possibly using variable 'geoip_error' before assignment (possibly-used-before-assignment)

and while it's true that the variables (WinColor, geoip_error) are
assigned conditionally, their use is protected (indirectly) by the same
conditionals.
@mgedmin mgedmin requested a review from cjmayo May 20, 2024 11:12
Copy link
Contributor

@cjmayo cjmayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgedmin mgedmin merged commit 6bfea13 into master May 21, 2024
10 checks passed
@mgedmin mgedmin deleted the pylint-errors branch May 21, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants