Bmm diag reduce logs #780
Open
Bmm diag reduce logs #780
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somandal
approved these changes
Nov 10, 2020
vmaheshw
reviewed
Nov 10, 2020
| @@ -92,8 +92,7 @@ public ServerComponentHealthAggregator(ZkClient zkClient, String cluster, int en | |||
| if (!errorMessage.isEmpty()) { | |||
| errorResponses.put(hostName, errorMessage); | |||
| } else { | |||
| String message = "Received REST response from the host: " + dmsUri + " with status: " + response.getStatus(); | |||
| LOG.info(message); | |||
| LOG.info("Received REST response from the host: " + dmsUri); | |||
There was a problem hiding this comment.
Can you please add another log in debug mode printing the response, in case we need to enable and verify it?
|
@jzakaryan is this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
statusinServerComponentHealthobject can be a very large string containing diagnostics information (per topic-partition offsets etc). Furthermore, in some use cases,ServerComponentHealthobjects retrieved from each host are being processed and for each one the status is printed. There's no need to print it in the logs. The response is returned to the client anyway.The change in this pull request removes the code that prints
statusofServerComponentHealth. It will reduce the amount of clutter in the logs.Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md