Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: response cookie extraction #3045

Open
wants to merge 2 commits into
base: v3.0
Choose a base branch
from

Conversation

floxay
Copy link
Contributor

@floxay floxay commented Jan 29, 2024

Fixes #3040

@floxay floxay requested review from a team as code owners January 29, 2024 01:32
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (43e3041) to head (21de2dd).
Report is 16 commits behind head on v3.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.0    #3045   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         322      322           
  Lines       14733    14736    +3     
  Branches     2343     2344    +1     
=======================================
+ Hits        14477    14480    +3     
  Misses        117      117           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good from my pov

Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable fix but a breaking change, so we’ll have to stash this for version 3.

@provinzkraut provinzkraut added 3.x This is related to Litestar version 3 Breaking 🔨 labels Feb 3, 2024
@provinzkraut provinzkraut added the Blocked 🚫 This is blocked by something label Feb 14, 2024
@peterschutt peterschutt changed the base branch from main to v3.0 March 26, 2024 01:49
@JacobCoffee
Copy link
Member

@floxay @provinzkraut can we merge this now

@provinzkraut provinzkraut force-pushed the response-cookie-extraction-change branch from a1e59c9 to 21de2dd Compare April 7, 2024 16:57
Copy link

github-actions bot commented Apr 7, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x This is related to Litestar version 3 Blocked 🚫 This is blocked by something Breaking 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ResponseDataExtractor merges per cookie attributes
3 participants