Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: patching models info #2269

Merged
merged 7 commits into from Apr 29, 2024
Merged

💄 style: patching models info #2269

merged 7 commits into from Apr 29, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Apr 28, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

对部分模型信息进行了纠错。

📝 补充信息 | Additional Information

close #2280

Copy link

vercel bot commented Apr 28, 2024

@sxjeru is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@sxjeru sxjeru marked this pull request as ready for review April 29, 2024 01:21
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要调整下~

src/config/modelProviders/google.ts Outdated Show resolved Hide resolved
src/config/modelProviders/groq.ts Outdated Show resolved Hide resolved
arvinxx

This comment was marked as outdated.

@arvinxx arvinxx changed the title 🔨 chore: patching models info 💄 style: patching models info Apr 29, 2024
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

额 单测挂了, 得修下单测~

@sxjeru
Copy link
Contributor Author

sxjeru commented Apr 29, 2024

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


https://github.com/sxjeru/lobe-chat/blob/7ffad5969a781efc6513cb274354d6313bd1eda5/src/store/user/slices/settings/selectors/modelProvider.test.ts#L128-L134
So the tokens of chat-bison-001 are left blank on purpose?

@sxjeru sxjeru requested a review from arvinxx April 29, 2024 09:51
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (721a2da) to head (c71114c).
Report is 1 commits behind head on main.

❗ Current head c71114c differs from pull request most recent head def9841. Consider uploading reports for the commit def9841 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
+ Coverage   92.67%   92.68%   +0.01%     
==========================================
  Files         290      290              
  Lines       16558    16554       -4     
  Branches     1911     1908       -3     
==========================================
- Hits        15345    15343       -2     
+ Misses       1213     1211       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Apr 29, 2024

没,之前是不知道 chat-bison-001 有多少token,就随便找了一个,这个单测要有,但是可以换个别的没指定token 的

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


No, I didn’t know how many tokens chat-bison-001 had before, so I just found one. This single test requires one, but you can change it to another one without specifying a token.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 3:35pm

@sxjeru
Copy link
Contributor Author

sxjeru commented Apr 29, 2024

检查过一遍,不存在缺少 tokens 的模型,目前是故意把 chat-bison-001 的 tokens 注释掉,毕竟已过时。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


After checking, there is no model that lacks tokens. Currently, the tokens of chat-bison-001 are commented out intentionally because they are outdated after all.

@arvinxx
Copy link
Contributor

arvinxx commented Apr 29, 2024

可以的

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


OK

@arvinxx arvinxx merged commit 03bcb06 into lobehub:main Apr 29, 2024
2 of 3 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
### [Version 0.151.3](v0.151.2...v0.151.3)
<sup>Released on **2024-04-29**</sup>

#### 💄 Styles

- **misc**: Patching models info.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Patching models info, closes [#2269](#2269) [#22802280](https://github.com/lobehub/lobe-chat/issues/22802280) ([03bcb06](03bcb06))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.151.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Apr 30, 2024
### [Version&nbsp;1.31.1](v1.31.0...v1.31.1)
<sup>Released on **2024-04-30**</sup>

#### ♻ Code Refactoring

- **misc**: Move app page to the `(main)` layout group.

#### 🐛 Bug Fixes

- **misc**: Effectively interrupt auto scrolling, fix only inject welcome question in inbox, plugins with multiple settings cannot be correctly configured.

#### 💄 Styles

- **misc**: Add 404 and Error page, patching models info, Revise some text.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Move app page to the `(main)` layout group, closes [lobehub#2297](https://github.com/bentwnghk/lobe-chat/issues/2297) ([6cc2c38](6cc2c38))

#### What's fixed

* **misc**: Effectively interrupt auto scrolling, closes [lobehub#2223](https://github.com/bentwnghk/lobe-chat/issues/2223) ([afe4974](afe4974))
* **misc**: Fix only inject welcome question in inbox, closes [lobehub#2289](https://github.com/bentwnghk/lobe-chat/issues/2289) ([cc8edd3](cc8edd3))
* **misc**: Plugins with multiple settings cannot be correctly configured, closes [lobehub#1991](https://github.com/bentwnghk/lobe-chat/issues/1991) ([0c041aa](0c041aa))

#### Styles

* **misc**: Add 404 and Error page, closes [lobehub#2299](https://github.com/bentwnghk/lobe-chat/issues/2299) ([938a3e9](938a3e9))
* **misc**: Patching models info, closes [lobehub#2269](https://github.com/bentwnghk/lobe-chat/issues/2269) [#22802280](https://github.com/bentwnghk/lobe-chat/issues/22802280) ([03bcb06](03bcb06))
* **misc**: Revise some text, closes [lobehub#2296](https://github.com/bentwnghk/lobe-chat/issues/2296) ([018427f](018427f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add MiniMax new models
3 participants