Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the reason why I've made these changes.
We have three ways to pass options to a generator.
I will take the discoverer as an example.
It has an option
views
with the default value of true. The generator fails to assign the value of theviews
from the config object as in the base-generator, the condition would always be true. The object this.options will have the views set to true (the default). This is the line if (!this.options[o]) {.Please note that this happens only when a generator has an option with the default value being truthy (views in discoverer & server option in openapi generator)
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated馃憠 Check out how to submit a PR 馃憟