Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add prefix to openapi generator #10350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Feb 7, 2024

The lb4 openapi generator can accept a prefix to add to the resources generated based on the provided specs.

Initially, I added this to fix this issue. But I thought of this as a feature for users to generate APIs for more than one openapi specs by adding a prefix to them.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@aaqilniz aaqilniz changed the title add prefix to openapi generator feat(cli): add prefix to openapi generator Feb 7, 2024
@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 8877428755

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feat/openapi-prefix at 55.332%

Totals Coverage Status
Change from base Build 8861530642: 55.3%
Covered Lines: 9563
Relevant Lines: 12458

馃挍 - Coveralls

@aaqilniz
Copy link
Contributor Author

aaqilniz commented Feb 7, 2024

Hi, @samarpanB. Can you please have a look at this PR?

@aaqilniz aaqilniz marked this pull request as ready for review February 7, 2024 14:35
Signed-off-by: Muhammad Aaqil <aaqilniz@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lb4 openapi doesn't work with openapi specs generated by loopback itself
2 participants