Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change dataSource to datasource #10438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change dataSource to datasource #10438

wants to merge 1 commit into from

Conversation

warisniz02
Copy link

@warisniz02 warisniz02 commented Mar 24, 2024 •
edited by aaqilniz

The lb4 discoverer names the argument to pass datasource as "dataSource". This PR makes the argument consistent with the lb4 datasource.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@coveralls
Copy link

coveralls commented Mar 30, 2024 •
edited

Pull Request Test Coverage Report for Build 8738018459

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.371%
Totals Coverage Status
Change from base Build 8721360373: 0.0%
Covered Lines: 9563
Relevant Lines: 12457
馃挍 - Coveralls

@warisniz02 warisniz02 force-pushed the fix/datasource-consistency branch 2 times, most recently from 6a4d7fc to d2d223f Compare April 18, 2024 12:37
@warisniz02
Copy link
Author

@dhmlau please have a look at my PR.

@aaqilniz aaqilniz requested a review from samarpanB April 30, 2024 18:19
@warisniz02
fix: change dataSource to datasource for consistency
347337b 
Signed-off-by: warisniz02 <warisniz02@gmail.com>
aaqilniz
aaqilniz approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@aaqilniz aaqilniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It becomes consistent with other commands. rest-crud uses keyword datasource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaqilniz aaqilniz aaqilniz approved these changes

@samarpanB samarpanB Awaiting requested review from samarpanB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@warisniz02 @coveralls @aaqilniz