New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper parameter name for api method #10493

Open

aaqilniz wants to merge 1 commit into loopbackio:master from aaqilniz:fix/method-param

+88 −13

Contributor

aaqilniz commented Apr 30, 2024

Generating APIs based on openapi specs generated by loopback 4 fails to name method parameters if it has a dash (-). This PR fixes it.

Checklist

DCO (Developer Certificate of Origin) signed in all commits
npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈


          fix: proper parameter name for api method

b4f3a33

Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>

coveralls commented Apr 30, 2024

Pull Request Test Coverage Report for Build 8899361532

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on fix/method-param at 55.332%

Totals
Change from base Build 8861530642:	55.3%
Covered Lines:	9563
Relevant Lines:	12458

💛 - Coveralls

aaqilniz marked this pull request as ready for review

April 30, 2024 18:18

aaqilniz requested a review from raymondfeng as a code owner

April 30, 2024 18:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment