Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't add Service URL Disord embed field if empty #4495

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NihadBadalov
Copy link

@NihadBadalov NihadBadalov commented Feb 15, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3327

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like a different approach:

  • lets drop the Service Type/Service URL distinction. No other monior has this destinction.
  • instead of having this in two different places, extracting the fields creation should be extracted into a different method.

@CommanderStorm CommanderStorm marked this pull request as draft March 26, 2024 22:49
@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Apr 3, 2024
@CommanderStorm CommanderStorm added the needs:work this PR needs work label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications needs:work this PR needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discord] Service URL should only be included if defined
2 participants