Fix overhead when loading directory #771
Conversation
* This avoids loading content of parent directories, only adding the requested directory. * This drastically reduces the amount of fstat system calls, and avoid superfluous items in the response array, i.e. files from directories we don't necessarily care about. * This should reduce timeouts when loading directories with large numbers of files.
|
+1 please merge this |
|
That changed the average loading time for folders from 10 seconds to 30ms. That is a huge improvement. |
|
@lrsjng Please can you merge this!? It seems a simple fix with a lot performance boost. #ty |
|
This repo has been dead for a while. It seems most development has stopped when main developer stopped. This repo seems to have most of the PRs merged I'm not using h5ai so much any more and plus I don't have so much time to maintain a fork myself. |
:-/ Didn't know that … Ty @hartmark for the info!
Also ty for this info, I'll look into it. Update + FYI: I couldn't figure out the explicit Commit, but I can confirm that the patch (from this PR) is implemented (in the new repo). – So ty @glubsy + @tudorminator, too! KR |
|
Side note: tudorminator's fork seems to have exactly the same commits as my fork currently. |
|
+1 vote for @glubsy as new benevolent dictator 😀 |
requested directory.
superfluous items in the response array, i.e. files from directories we
don't necessarily care about.
of files.
The timeout reduction will probably fix #753, fix #629, fix #518, fix #458, fix #752.