Set background color on fallback icons for IE6 #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internet Explorer 6 is widely known to not support PNG transparency unless CSS hacks are applied; instead of transparency, it renders a hidden background color contained in the file, which is often not accounted for, making the current fallback icons render with a light blue background. This PR changes the fallback icons to have a hidden background color of
#FFFFFFinstead, which blends in nicely with the fallback theme's default white background.The background color was changed using
convert in.png -background '#ffffff' out.pngand the resulting files were processed withzopflipngpngquant, which isn't as good aszopflipngbut doesn't strip the background color data.