Added nightly workflow #862
Conversation
| - run: npm run build | ||
|
|
||
| - name: ZIP Executable | ||
| if: steps.commitswithintime.outputs.has-new-commits-within-time != 'false' |
There was a problem hiding this comment.
I don't see this step in this workflow. - Copy and paste error?
There was a problem hiding this comment.
the name should give out what it does, it's zipping the builded files, also yes it's in the workflow
| fail-fast: false | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3.0.2 |
There was a problem hiding this comment.
Because its the latest release with a newer NodeJS version and will not lead to depreciation warnings. See https://github.com/actions/checkout/releases/tag/v4.0.0
| with: | ||
| fetch-depth: 1 |
| - name: Build with npm | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 10.15 |
There was a problem hiding this comment.
Why this old node version? Please add a comment if this is really required. Otherwise, I would propose to use v20 (LTS)
There was a problem hiding this comment.
Pretty sure h5ai as a whole got an issue building with newer versions of node, did you try to build the program yourself?
There was a problem hiding this comment.
Then a code comment could be added to make it clear. It might happen that someone activates dependabot...
|
sir i made this PR 6 months ago, how do you expect me to remember any of this, also why are you even asking all of these things in the first place lol |
|
@glubsy why don't you answer these instead of making a thumbs down emoji lol |
|
@biast12 I thought the comment was nor warranted nor necessary, that's all. No need to justify not remembering code from a while back, if you can't answer the questions, just don't answer them 😛 anyway don't take it personally 😉 |
|
Sorry but i find it a bit weird code review someone code from half a year ago with questions that would have been answered if he just build the program |
Because I am also a user of h5ai and just stumbled on this PR. Wanted to reduce load for the original maintainer.... |
I think general questions on the workflow such as " fetch-depth: 1" can be answered without building ✌️ |
|
a month later lmao 😂 |
And not a year later. ✌️ I wish you that for your free time projects you manage to have fast response times. And that you manage to contribute to many projects to spread your wisdom! |
Nightly automatically builds a release of the app and uploads it to a release, the only thing you gotta do is make a release specially for this and get the release_id and change the
118815966in this code, you can get the release_id at https://api.github.com/repos/lrsjng/h5ai/releases, and take the number under the name of the release and id (should be 9 numbers), and change the branches from workflow to master (assuming you want it to use the master branch)when that's changed should it completely build a release every time someone commits something to the repo, you can see an example of it here: https://github.com/biast12/h5ai/releases/tag/Release