-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add multiple cards as user interface components for the new sidebar
#8554
Conversation
WalkthroughThe recent updates introduce a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
src/main/webapp/app/shared/sidebar/sidebar-card-medium/sidebar-card-medium.component.scss
Show resolved
Hide resolved
src/main/webapp/app/shared/sidebar/sidebar-card-large/sidebar-card-large.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/sidebar/sidebar-card-medium/sidebar-card-medium.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/sidebar/sidebar-accordion/sidebar-accordion.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/sidebar/sidebar-card-medium/sidebar-card-medium.component.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainer approved
# Conflicts: # src/main/webapp/app/overview/course-overview.service.ts
578302a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
src/main/webapp/app/overview/course-overview.service.ts (1)
Line range hint
25-25
: Add missing import forTranslateService
.+ import { TranslateService } from '@ngx-translate/core';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove after merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
Development
: Created Multiple Cards and for New SidebarDevelopment
: Add multiple cards as user interface components for the new sidebar
Checklist
General
Client
Description
This PR introduces cards of varying sizes "small", "medium", and "large" that are designed to deliver content tailored to the specific needs of different modules, such as lectures, exercises, and conversations. Additionally, a directive has been implemented to facilitate the generation of these cards
Note: This PR only contains the card components. The application of these cards in specific sidebar configurations will be addressed in following PRs. "The reason this PR is separated from its usage is that these cards will be utilized by other developers in the near future."
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Test Coverage
Screenshots
Small Sidebar Card Example (From a draft branch)
Medium Sidebar Card Example (Currently used, default size)
Large Sidebar Card Example (From a draft branch)